fix(select): improve screen reader announcement timing for validation errors #30723
+482
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
package: core
thetaPC
requested review from
OS-jacobbell and
brandyscarney
and removed request for
OS-jacobbell
brandyscarney
approved these changes
Oct 13, 2025
| * since promises are high priority. | ||
| */ | ||
| Promise.resolve().then(() => { | ||
| this.hintTextID = this.getHintTextID(); |
There was a problem hiding this comment.
Why do we use a state here instead of calling forceUpdate?
There was a problem hiding this comment.
The comment looks like it describes why, though it may have been added after (I appreciate it either way). Maybe @thetaPC found this more reliable than my method of using forceUpdate? My attempt was not perfect, so a more reliable method would be great
There was a problem hiding this comment.
@brandyscarney I've updated the comment to explain it a bit better: 641f250
| * Checks if the input is in an invalid state based | ||
| * on Ionic validation classes. | ||
| */ | ||
| private checkInvalidState(): boolean { |
There was a problem hiding this comment.
Can we move this to a shared util file since it's used by multiple components?
ShaneK
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, when an error text is shown, it may not announce itself to voice assistants. This is because the way error text currently works is by always existing in the DOM, but being hidden when there is no error. When the error state changes, the error text is shown, but as far as the voice assistant can tell it's always been there and nothing has changed.
What is the new behavior?
We had to do this with a mutation observer and state because it's important in some frameworks, like Angular, that state changes to cause a re-render. This, combined with some minor aria changes, makes it so that when a field is declared invalid, it immediately announces the invalid state instead of waiting for the user to go back to the invalid field.
Does this introduce a breaking change?
Other information
Preview