Skip to content

Remove direct github.com/pkg/errors usage#756

Open
MukundaKatta wants to merge 1 commit into
ionos-cloud:mainfrom
MukundaKatta:codex/remove-pkg-errors
Open

Remove direct github.com/pkg/errors usage#756
MukundaKatta wants to merge 1 commit into
ionos-cloud:mainfrom
MukundaKatta:codex/remove-pkg-errors

Conversation

@MukundaKatta
Copy link
Copy Markdown

Description

  • replace direct github.com/pkg/errors imports with the standard library errors and fmt
  • preserve wrapping with %w where callers rely on errors.Is or errors.As
  • keep nil-wrap behavior in requeue paths that previously depended on errors.Wrap(nil, ...) returning nil
  • move github.com/pkg/errors from direct to indirect in go.mod, since it is still pulled in transitively

Fixes #654

Testing

  • go test ./internal/service/vmservice ./internal/inject ./pkg/cloudinit ./pkg/ignition ./pkg/kubernetes/ipam ./pkg/proxmox/goproxmox ./pkg/scope
  • go test ./... (fails locally because envtest cannot find /usr/local/kubebuilder/bin/etcd; non-envtest packages run and pass)
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop using github.com/pkg/errors as it is unmaintained

1 participant