Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/did key #1374

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Feat/did key #1374

wants to merge 12 commits into from

Conversation

eike-hass
Copy link
Collaborator

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eike-hass eike-hass requested a review from a team as a code owner May 30, 2024 14:05
@eike-hass eike-hass marked this pull request as draft May 30, 2024 14:20
@UMR1352
Copy link
Contributor

UMR1352 commented Jun 24, 2024

@eike-hass what do we want to do with this? The implementation only supports a portion of the did:key specification and has not been thoroughly documented nor tested

@eike-hass
Copy link
Collaborator Author

eike-hass commented Jun 24, 2024

@eike-hass what do we want to do with this? The implementation only supports a portion of the did:key specification and has not been thoroughly documented nor tested

we need did:key support for Selv and might need to extend to did:jwk es well. I think we should be okay with only considering ed25519 support for now though and rethink for 2.0.
Long story short: We should try to get this in an acceptable state and merge mid-term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants