libbpf tcptop: Fix "unrecognized bpf_ld_imm64 insn" on 4.19 #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardkaindl
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
Fix the BPF load error `unrecognized bpf_ld_imm64 insn` on 4.19 by converting rodata config variables to a map. tcptop can use CO-RE including 4.19 when a detached vmlinux BTF file is provided, generated from a DWARF vmlinux using pahole: pahole -J;objcopy --only-section=.BTF vmlinux /boot/vmlinux-$(uname -r) Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
force-pushed
the
libbpf-tcptop-fix-unrecognized-ld_imm64
branch
from
80a6345
to
c237605
Compare
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
force-pushed
the
libbpf-tcptop-fix-unrecognized-ld_imm64
branch
from
b698ac3
to
8b03d14
Compare
| @@ -12,9 +12,12 @@ | |||
| #define AF_INET 2 /* Internet IP Protocol */ | |||
| #define AF_INET6 10 /* IP version 6 */ | |||
|
|
|||
| const volatile bool filter_cg = false; | |||
| const volatile pid_t target_pid = -1; | |||
| const volatile int target_family = -1; | |||
There was a problem hiding this comment.
The above coding pattern has been used in most of libbpf-tools bpf programs. I would rather to keep this. Changing to use map does not sound good compared to more elegant way in the above. 4.19 is quite old. Maybe you could folk the repo and make change in your private repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the BPF load error
unrecognized bpf_ld_imm64 insnintcptopon 4.19 by converting.rodataconfig variables to a map. (global data is not supported in 4.19)tcptopcan use CO-RE including on 4.19 when a detachedvmlinuxBTF file is provided.It can be generated from a DWARF
vmlinuxusingpahole:PS: GitHub CI fails on a few test cases (flaky) so I added a minor commits to make CI less flaky.