Skip to content

Add scripts to verify compatibility with multiple Python versions #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2021

Conversation

c0llab0rat0r
Copy link
Contributor

Carved out of #257

Adds scripts that use Docker to verify the library's compatibility with the versions of Python it supports.

With this change, the travis build will still fail with style linting and type linting errors. Change #257 will correct the style linting errors, and this change will be rebased once that one is merged.

Once #257 and this change are both merged, the scripts in this change will fail on the first Python version, 3.5.4, because the current code base has syntax at

that is not supported by 3.5.4 - this problem will be corrected by #258.

@c0llab0rat0r c0llab0rat0r force-pushed the verify-with-docker branch 2 times, most recently from 94a0396 to b611920 Compare April 9, 2021 15:10
@c0llab0rat0r
Copy link
Contributor Author

Build error for Windows appears transient:

# Daemon should not be running anymore
>   	assert not daemon_is_running()
E    assert not True
E     +  where True = <function test_daemon_stop.<locals>.daemon_is_running at 0x000001BD05C99820>()

@c0llab0rat0r
Copy link
Contributor Author

./verify.sh 3.8.0 will pass.

./verify.sh 3.7.2 and 3.6.2 will fail, with problems related to flake8 and typing.Final not being present in versions of Python prior to 3.8.

@c0llab0rat0r
Copy link
Contributor Author

Unrelated transient failure on existing build process on Windows; does not exercise new scripts which are only run manually and locally.

@c0llab0rat0r
Copy link
Contributor Author

Added a commit to add support for Python 3.9 since that was added to the library dependencies and build recently.

Using these new scripts:

  • Python 3.6.2 will fail - flake fails to load a flake plugin that uses typing.Final, which is not supported on Python 3.6
  • Python 3.7.2 will fail - this library uses Literal which is not supported on Python 3.7
  • Python 3.8.0 will pass
  • Python 3.9.0 will pass

We might be using a version of flake that is too new to use with Python 3.6.

@c0llab0rat0r
Copy link
Contributor Author

@c0llab0rat0r
Copy link
Contributor Author

Rebased from master; ready to go.

@ntninja
Copy link
Contributor

ntninja commented May 15, 2021

Thanks! 🙂

@ntninja ntninja merged commit 91bdaba into ipfs-shipyard:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants