Conversation
2color
commented
Aug 12, 2025
| "sync-version": "node scripts/sync-version.mjs", | ||
| "build": "npm run sync-version && tsc && cp src/manifest.json dist/ && cp src/popup.html dist/ && cp -r src/icons dist/", | ||
| "package": "npm run build && web-ext build --source-dir=dist --artifacts-dir=. --filename=ipfs-quicklaunch-{version}.zip --overwrite-dest", | ||
| "package": "npm run build && web-ext build --source-dir=dist --artifacts-dir=. --filename=ipfs-quicklaunch.zip --overwrite-dest", |
Contributor
Author
There was a problem hiding this comment.
@lidel Was there any reason to include the version in the zip file?
This makes it a bit harder to automate the publishing, so I changed to a static name to keep things simple.
Contributor
There was a problem hiding this comment.
no hard reason, it is just a convention of mine, makes it easy to work with artifacts if you download multiple versions for regression testing, but fine to remove version from name if it makes things easier.
lidel
approved these changes
Aug 12, 2025
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that I've added the secrets based on https://developer.chrome.com/docs/webstore/using-api?hl=en to the repo
Notes