Skip to content

Commit

Permalink
Add channel last pass in global opt
Browse files Browse the repository at this point in the history
just using it in preprocessing breaks with qunatized convs

Signed-off-by: Nirvedh <[email protected]>
  • Loading branch information
nirvedhmeshram committed Dec 18, 2024
1 parent 401e33d commit 0fed6e7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion compiler/src/iree/compiler/GlobalOptimization/Passes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

#include "iree/compiler/GlobalOptimization/Passes.h"
#include "iree/compiler/Preprocessing/Passes.h"
#include "iree/compiler/Preprocessing/Common/Passes.h"
#include "iree/compiler/Dialect/Flow/IR/FlowDialect.h"
#include "iree/compiler/Dialect/Flow/Transforms/Passes.h"
#include "iree/compiler/Dialect/Util/Transforms/Passes.h"
Expand Down Expand Up @@ -102,7 +104,9 @@ void buildGlobalOptimizationPassPipeline(
.addPass(IREE::Flow::createCanonicalizerPass)
.addPass(createRemoveZeroExtentTensorsPass)
.addPass(createDetachElementwiseFromNamedOpsPass)
.addPass(mlir::createLinalgNamedOpConversionPass);
.addPass(mlir::createLinalgNamedOpConversionPass)
.addPass(Preprocessing::createConvertConvToChannelsLastPass)
.addPass(GlobalOptimization::createConvert1X1FilterConv2DToMatmulPass);
mainPassManager.addPass(createEraseUnusedLinalgOperandsPass());

// Expand tensor shapes into SSA values and optimize the whole program.
Expand Down
4 changes: 2 additions & 2 deletions compiler/src/iree/compiler/Preprocessing/Passes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ buildTransposeConvolutionPassPipeline(OpPassManager &passManager,
FunctionLikeNest(passManager)
.addPass(GlobalOptimization::createDetachElementwiseFromNamedOpsPass)
.addPass(mlir::createLinalgNamedOpConversionPass)
.addPass(GlobalOptimization::createConvert1X1FilterConv2DToMatmulPass)
.addPass(createConvertConvToChannelsLastPass);
.addPass(createConvertConvToChannelsLastPass)
.addPass(GlobalOptimization::createConvert1X1FilterConv2DToMatmulPass);
passManager.addPass(DispatchCreation::createFoldUnitExtentDimsPass());
passManager.addPass(createCanonicalizerPass());
passManager.addPass(createCSEPass());
Expand Down

0 comments on commit 0fed6e7

Please sign in to comment.