Skip to content

Commit

Permalink
Fix correctness issue
Browse files Browse the repository at this point in the history
Remove check from collapse dimensions to paper over correctness issue
  • Loading branch information
IanWood1 committed Sep 8, 2024
1 parent 60edb94 commit 3564b56
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions compiler/src/iree/compiler/DispatchCreation/CollapseDimensions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -170,23 +170,6 @@ static bool isEligibleForCollapse(linalg::GenericOp genericOp) {
if (genericOp.hasIndexSemantics())
return false;

// TODO(#17948) GPU codegen fails when we collapse the dimensions of softmax.
if (llvm::any_of(genericOp.getDpsInputOperands(),
[&](OpOperand *operand) -> bool {
auto genericOperand =
operand->get().getDefiningOp<linalg::GenericOp>();
if (!genericOperand)
return false;

if (genericOperand.getNumReductionLoops() == 0)
return false;

return genericOp.getMatchingIndexingMap(operand)
.isProjectedPermutation();
})) {
return false;
}

return true;
}

Expand Down

0 comments on commit 3564b56

Please sign in to comment.