Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-land e2e attention test suite. #18320

Merged
merged 9 commits into from
Aug 22, 2024

Conversation

erman-gurses
Copy link
Member

Add the e2e test suite for the Attention. It only checks CPU FP16, and the reference implementation is FP32.
#17751
#18302

@erman-gurses erman-gurses self-assigned this Aug 21, 2024
@erman-gurses erman-gurses requested a review from benvanik as a code owner August 21, 2024 21:54
@ScottTodd
Copy link
Member

Please structure this as two commits: one that is the original changes and one that has any new changes since the last review.

Please also change the PR title to directly reflect what is being added, e.g. "Re-land e2e attention test suite."

Signed-off-by: erman-gurses <[email protected]>
@erman-gurses erman-gurses changed the title Add reverted changes from PR #18302 Re-land e2e attention test suite. Aug 21, 2024
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
@erman-gurses erman-gurses merged commit 588732c into iree-org:main Aug 22, 2024
36 checks passed
erman-gurses added a commit that referenced this pull request Aug 27, 2024
Add HIP Backend test support for attention FP16.
It is based on this test suite:
#18320

---------

Signed-off-by: erman-gurses <[email protected]>
erman-gurses added a commit to iree-org/iree-test-suites that referenced this pull request Nov 16, 2024
Progress on this #2
This PR refactors, adds, and migrates Attention e2e tests from the PR
here: iree-org/iree#18320

---------

Signed-off-by: erman-gurses <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants