[Flow] Fix cloning of flow.tensor.transfer into dispatch
#19838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
changed the title
IanWood1
changed the title
flow.tensor.transfer into dispatch
IanWood1
force-pushed
the
attn_mask
branch
2 times, most recently
from
8020236 to
2b8dacc
Compare
MaheshRavishankar
approved these changes
Feb 12, 2025
Signed-off-by: Ian Wood <[email protected]>
hanhanW
pushed a commit
to hanhanW/iree
that referenced
this pull request
Feb 13, 2025
…19838) Fixes case where `flow.tensor.transfer` was getting cloned into dispatches with an attention op by not cloning any `Flow` ops. This happens because `isAttentionMaskGenerator` returns true for all ops that are used by attention ops (including flow ops). Signed-off-by: Ian Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes case where
flow.tensor.transferwas getting cloned into dispatches with an attention op by not cloning anyFlowops. This happens becauseisAttentionMaskGeneratorreturns true for all ops that are used by attention ops (including flow ops).