[NFC][Im2Col] Move im2col to affine.delinearize_index #19840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the generated indexing code in im2call by using affine.delineraize_index instead of affine::delinearizeIndex.
hanhanW
changed the title
hanhanW
reviewed
Feb 3, 2025
Comment on lines
789
to
792
| auto delinKOffsetOp = b.create<affine::AffineDelinearizeIndexOp>( | ||
| nestedLoc, getValueOrCreateConstantIndexOp(b, loc, kIndex), kBasis, | ||
| /*hasOuterBound=*/true); | ||
| SmallVector<Value> delinKOffset = delinKOffsetOp.getResults(); |
There was a problem hiding this comment.
I think we can just collapse them into a single statement because we do not use the op elsewhere.
Suggested change
| auto delinKOffsetOp = b.create<affine::AffineDelinearizeIndexOp>( | |
| nestedLoc, getValueOrCreateConstantIndexOp(b, loc, kIndex), kBasis, | |
| /*hasOuterBound=*/true); | |
| SmallVector<Value> delinKOffset = delinKOffsetOp.getResults(); | |
| SmallVector<Value> delinKOffset = b.create<affine::AffineDelinearizeIndexOp>( | |
| nestedLoc, getValueOrCreateConstantIndexOp(b, loc, kIndex), kBasis, | |
| /*hasOuterBound=*/true).getResults(); |
Comment on lines
823
to
826
| auto delinMOffsetOp = b.create<affine::AffineDelinearizeIndexOp>( | ||
| nestedLoc, getValueOrCreateConstantIndexOp(b, loc, linearMOffset), mBasis, | ||
| /*hasOuterBound=*/true); | ||
| SmallVector<Value> delinMOffset = delinMOffsetOp.getResults(); |
There was a problem hiding this comment.
ditto, we can just collapse them into a single statement.
hanhanW
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the generated indexing code in im2col by using affine.delineraize_index instead of affine::delinearizeIndex.