[LLVMGPU] Add a verifier for tile sizes. #19906
Open
+53
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
erman-gurses
changed the title
Signed-off-by: erman-gurses <[email protected]>
erman-gurses
changed the title
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
erman-gurses
force-pushed
the
users/erman-gurses/tilesize-verifier
branch
22 times, most recently
from
a462b4f to
ae7e5a6
Compare
erman-gurses
force-pushed
the
users/erman-gurses/tilesize-verifier
branch
21 times, most recently
from
0a7e8fd to
8a9f54d
Compare
Signed-off-by: erman-gurses <[email protected]>
erman-gurses
force-pushed
the
users/erman-gurses/tilesize-verifier
branch
from
8a9f54d to
09f2633
Compare
erman-gurses
requested review from
MaheshRavishankar,
qedawkins,
kuhar and
Groverkss
as code owners
qedawkins
requested changes
Feb 18, 2025
| getLoweringConfig<IREE::Codegen::LoweringConfigAttr>(op); | ||
| if (!loweringConfig) | ||
| auto gpuLoweringConfig = | ||
| getLoweringConfig<IREE::GPU::LoweringConfigAttr>(op); |
There was a problem hiding this comment.
Rather than casting and passing two lowering config attributes, it would be cleaner to add an additional template parameter to this function (template <typename F, typename ConfigTy>) and only cast to the config type that works for F. Then rather than combining the verifiers for LLVMGPUMatmulTensorCoreMmaSync and LLVMGPUVectorDistribute, we have two separate verifyGPUMatmulPipeline functions, one for the GPU lowering config and one for the Codegen lowering config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a verifier for tile sizes.