Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fixing execution region result placement. (#19872)" #19958

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stbaione
Copy link

This reverts the changes to SchedulingExecution.cpp from commit 4fffb0e.

This change caused corrupt tokens to be outputted from sharded llama models (#19948).

After bisecting, I was able to get good outputs again after reverting the specific changes to ScheduleExecution.cpp.

This reverts the changes to `SchedulingExecution.cpp` from commit 4fffb0e.

This change caused corrupt tokens to be outputted from sharded llama models (iree-org#19948)
@ScottTodd
Copy link
Member

If we want to publish a 3.2.1 patch release with this change, we would backport onto https://github.com/iree-org/iree/tree/v3.2.0 and follow the instructions at https://iree.dev/developers/general/release-management/#creating-a-patch-release

It would be our first time following those instructions, so I'm not sure if the commands are what we want... may want to stick to git tags and not create a branch...?

@stbaione
Copy link
Author

If we want to publish a 3.2.1 patch release with this change, we would backport onto https://github.com/iree-org/iree/tree/v3.2.0 and follow the instructions at https://iree.dev/developers/general/release-management/#creating-a-patch-release

It would be our first time following those instructions, so I'm not sure if the commands are what we want... may want to stick to git tags and not create a branch...?

Gotcha, I can try that. I was originally going to push to iree-org directly (hence branch name), but created this fork, since I didn't have proper permissions. I assume I'll need them to be enabled to create the patch-release branch

@ScottTodd
Copy link
Member

I'd prefer for @marbre or myself to do the release branching. That type of work typically needs elevated permissions and has sharp edges to watch for. Let's work the problem on this PR and then decide if we want to go through the effort of publishing a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants