Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stream][NFC] Remove unnecessary IRs from specialize_encodings.mlir #20013

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Feb 18, 2025

The revision moves magic constants to input argument, and delete unnecessary IRs from tests. The original author (i.e., me) was not familiar with stream operations, so there were some copy-paste and experimental IRs.

@hanhanW hanhanW requested a review from benvanik as a code owner February 18, 2025 00:11
@hanhanW hanhanW enabled auto-merge (squash) February 18, 2025 00:23
@hanhanW hanhanW disabled auto-merge February 18, 2025 01:19
@hanhanW
Copy link
Contributor Author

hanhanW commented Feb 18, 2025

I need to update tests because of 33a770e. The commit breaks the pass in SDXL, I'll take a look at the failure first.

@hanhanW hanhanW enabled auto-merge (squash) February 18, 2025 20:46
@hanhanW hanhanW disabled auto-merge February 18, 2025 21:20
@hanhanW hanhanW enabled auto-merge (squash) February 18, 2025 21:22
@hanhanW hanhanW merged commit 0d49dac into iree-org:main Feb 18, 2025
38 of 39 checks passed
@hanhanW hanhanW deleted the simplify-test branch February 18, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants