Integrate LLVM to llvm/llvm-project@3e61c1ab7f #20015
Conversation
lialan
force-pushed
the
users/lialan/llvm_integration_20250217
branch
from
409a354 to
40104fc
Compare
lialan
force-pushed
the
users/lialan/llvm_integration_20250217
branch
from
f3067dc to
c24ba9e
Compare
Signed-off-by: Alan Li <[email protected]>
lialan
force-pushed
the
users/lialan/llvm_integration_20250217
branch
from
c24ba9e to
79e983c
Compare
lialan
requested review from
MaheshRavishankar,
rsuderman,
qedawkins,
hanhanW,
IanWood1,
antiagainst,
kuhar,
Groverkss,
pashu123,
benvanik and
ScottTodd
as code owners
| // CHECK: tensor.pack | ||
| // CHECK: tensor.unpack | ||
| // CHECK: linalg.pack | ||
| // CHECK: linalg.unpack |
There was a problem hiding this comment.
Can you please call out large changes like these in the PR description with some context? A link to the upstream commit (llvm/llvm-project@517800e, https://github.com/llvm/llvm-project/commit/517800e37e8d3a4ee84214bef65e227612c2a98b) would be ideal.
We don't have a PR template for LLVM integrates but here's what we usually look for:
-
Which upstream commit was chosen? This is partly in the PR title already, but you have save others some clicking by putting a link such as llvm/llvm-project@3e61c1ab7f (
https://github.com/llvm/llvm-project/commit/3e61c1ab7f) in the description. Bonus points for also making the PR title include the full form likellvm/llvm-project@3e61c1ab7f, so commit titles on GitHub create a link too (https://github.com/iree-org/iree/commits/main/third_party):
-
Are there any cherry-picks or reverts carried on our fork at https://github.com/iree-org/llvm-project, or is the integrate cleanly pointing to an upstream https://github.com/llvm/llvm-project commit?
-
What changes were noteworthy and needed changes to remain compatible? (at least the tensor->linalg change here)
There was a problem hiding this comment.
Ahh didn't know that you can save a click by putting llvm/llvm-project@3e61c1ab7f in the title. Thanks for the tip.
I also updated the PR title and the descriptions.
| // Cases of trivial pack/unpack should be handled as canonicalizations | ||
| // before we get here, thus we're safe to always hoist. |
There was a problem hiding this comment.
Nit: this comment should be moved up to the linalg section since the pack/unpack ops are no longer in tensor.
There was a problem hiding this comment.
I think even the name HoistableLinalgOpInterfaceHelper needs to be updated as well because it is no longer linalg specific.
lialan
changed the title
lialan
changed the title
[MLIR] Fix rewrite of ops with vector operands to LLVM on GPU. llvm/llvm-project#127844 Previously cherry-picked in #20031 and then dropped in #20015. Needed by the just-merged #19969. Signed-off-by: Benoit Jacob <[email protected]>
This PR contains the following change: