[Encoding][NFC] Move non attribute implementation to EncodingTypes.cpp #20045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It follows the convention, which only put the attribute implementation and local functions to EncodingAttr.cpp. The implementation of other utilities are moved to EncodingTypes.cpp. Signed-off-by: hanhanW <[email protected]>
kuhar
approved these changes
Feb 20, 2025
kuhar
reviewed
Feb 20, 2025
|
|
||
| FailureOr<linalg::ContractionDimensions> | ||
| getEncodingContractionDims(EncodingAttr encoding) { | ||
| auto indexingMapsAttr = encoding.getUserIndexingMaps(); |
There was a problem hiding this comment.
Would be nice to replace this auto and a few below with concrete types, since the type is not obvious based on the context. But if you don't want to do that in this PR that's fine -- I realize it's mostly code motion.
There was a problem hiding this comment.
I'm happy to do so, since I touch the code. :)
Signed-off-by: hanhanW <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It follows the convention, which only put the attribute implementation and local functions to EncodingAttr.cpp. The implementation of other utilities is moved to EncodingTypes.cpp.
Additionally, it spells out the types for
auto.