[GPU] fix bug in expand permutation calculation when concretizing MMA shapes #20049
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvedhmeshram
requested review from
antiagainst and
qedawkins
as code owners
… shapes Signed-off-by: Nirvedh <[email protected]>
nirvedhmeshram
force-pushed
the
concretize_bug
branch
from
40ee308 to
3ea89d5
Compare
qedawkins
reviewed
Feb 20, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/ConcretizeMmaShapes.cpp
Show resolved
Hide resolved
Signed-off-by: Nirvedh <[email protected]>
nirvedhmeshram
force-pushed
the
concretize_bug
branch
from
200b8e6 to
1292fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When expanding permutation during concretizing mma shapes. We want to first expand in the inverse domain and then take inverse of that.