[WIP][LinalgExt] Support iree_linalg_ext.index in attention ops for causal masks#24056
Closed
keshavvinayak01 wants to merge 1 commit intoiree-org:mainfrom
Closed
Conversation
… masking Express causal masking via iree_linalg_ext.index in the attention region body instead of an is_causal attribute. Teach decomposition to remap index ops to linalg.index via sMap, and tiling to apply offsets. Detect causal masks during TMTensor conversion via the is_causal attribute from llvm/torch-mlir#4520. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Express causal masking via iree_linalg_ext.index in the attention region body instead of an is_causal attribute. Decomposition remaps index ops to linalg.index via sMap, and tiling uses.offsets.
Aided by the addition of
is_causalto theTMTensor::AttentionOpin llvm/torch-mlir#4520.