-
Notifications
You must be signed in to change notification settings - Fork 74
[#519] correct regression with server_verify_mode of "none" #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. Has this been tested?
These changes were tested pre-review but not yet post-review. Likely I'll wait until after we've reviewed a few more PR's as a team and I've tested the changes all together, then we'll merge them all at once. That is just the more efficient way to do it at the moment, given the changes to the testing process that are in store for PRC v2.1.0 |
That sounds more error prone since you're handling multiple PRs, but if you feel that's the most efficient way to handle it on your end, then proceed. |
I felt it was the most efficient, if not overall best, way. But I don't think it adds any extra opportunity for error, any more than the requisite Git mechanics. |
Changing commit message to exclude #281 in head-line per #508 (comment) |
Tested and passing. To resolve "critical" codacy comment (re unexpected parameter |
Squash to taste if ready, no pounds. We'll hold on merging this one until #527 is merged. |
… explicitly none Fixes a regression on issue irods#281.
No description provided.