Skip to content

Conversation

d-w-moore
Copy link
Collaborator

No description provided.

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Has this been tested?

@d-w-moore
Copy link
Collaborator Author

d-w-moore commented Apr 10, 2024

Seems good. Has this been tested?

These changes were tested pre-review but not yet post-review. Likely I'll wait until after we've reviewed a few more PR's as a team and I've tested the changes all together, then we'll merge them all at once. That is just the more efficient way to do it at the moment, given the changes to the testing process that are in store for PRC v2.1.0

@korydraughn
Copy link
Contributor

That sounds more error prone since you're handling multiple PRs, but if you feel that's the most efficient way to handle it on your end, then proceed.

@d-w-moore
Copy link
Collaborator Author

d-w-moore commented Apr 11, 2024

That sounds more error prone since you're handling multiple PRs, but if you feel that's the most efficient way to handle it on your end, then proceed.

I felt it was the most efficient, if not overall best, way. But I don't think it adds any extra opportunity for error, any more than the requisite Git mechanics.

@d-w-moore
Copy link
Collaborator Author

Changing commit message to exclude #281 in head-line per #508 (comment)

@d-w-moore
Copy link
Collaborator Author

d-w-moore commented Apr 22, 2024

Tested and passing. To resolve "critical" codacy comment (re unexpected parameter ssl_dir) this PR should follow #527 in the merge order.

@korydraughn
Copy link
Contributor

Squash to taste if ready, no pounds.

We'll hold on merging this one until #527 is merged.

@alanking alanking merged commit 80065d9 into irods:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants