Fix the InSAR offsets products QA failure where there are multiple col pols #181
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
September 19, 2023 20:40
xhuang-jpl
requested review from
Tyler-g-hudson,
hfattahi,
nemo794,
oberonia78 and
seongsujeong
Tyler-g-hudson
approved these changes
Dec 19, 2025
Contributor
Tyler-g-hudson
left a comment
Tyler-g-hudson
left a comment
There was a problem hiding this comment.
LGTM, at least in terms of logic
nemo794
requested changes
Dec 19, 2025
Contributor
nemo794
left a comment
nemo794
left a comment
There was a problem hiding this comment.
Hi @xhuang-jpl , Thanks for putting up this PR to force the conversation! You're correct in that this creates a bit of a mess with QA and with the product specs. I'm going to block the merging for now to prevent any accidents, until the team discusses and agrees upon the correct path forward. Thank you again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue:
The default InSAR populate ONLY ONE co-pol offset products (HH first, VV second) because of the runconfig parameter (process_single_co_pol_offset) here. The InSAR writer mis-used the polarizations from the function get_cfg_freq_pols where the third returned parameters are the polarization from the offsets products, but it used the second return parameters. This triggers the inconsistency between the InSAR writer and offset products, which means that the VV offsets will be created in the InSAR products, but not in the offsets products.
The solution:
Update the InSAR writer to use the right polarizations being consistent with the offsets products.
The caveat:
how we will populate the listOfPolarizations in the RIFG, RUNW, and GUNW products? I mean the interferograms will have two co-polarizations, but the pixelOffsets will have one co-pol polarization, which might fail the QA?