LUT2d: Fix python crash on out of bounds array .eval()
#188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `LUT2d.eval()` on out‐of‐bounds coordinates behaves inconsistently depending on whether you pass Python floats or NumPy arrays: - With two floats, the call prints a journal warning and raises a catchable `RuntimeError`. - With a float + NumPy array (or two arrays), you see the journal warning, but Python aborts with an uncaught `pyre::journal::application_error`.
Tyler-g-hudson
approved these changes
Dec 17, 2025
Contributor
Tyler-g-hudson
left a comment
Tyler-g-hudson
left a comment
There was a problem hiding this comment.
Appears useful, and the logic makes sense. LGTM
@hfattahi We've got a handful of orphan PR's like this, when we've got time it'd be good to formulate a plan for reviewing them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.evalCloses #187