-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MWE Schemes #38
base: master
Are you sure you want to change the base?
Conversation
Hi @pegasus-lynx thanks for the pull request. I will gladly review it, and look forward to merging it. Thanks again for submitting the PR! Its looking good. |
Hey @pegasus-lynx I tried to test these new features. But I am clueless regarding how to use this API. A simple test case for creating vocab would do; here is an example: Lines 20 to 39 in b99d023
AND/OR a sample usage e.g. https://github.com/isi-nlp/nlcodec/blob/master/docs/intro.adoc#python-api so we Thanks. Once again, I apologize for the delay. |
@pegasus-lynx let me know if this is ready for a review! |
Hey @thammegowda, sorry for the delay. We have moved in a different direction with this branch. I will close this PR and create a new PR for this. As of now, the SkipScheme has some issues in decoding, so it is still not ready for review. |
Hello Team,
We have been trying to add the support for ngrams and skipgrams into nlcodec. The PR above does the following:
The implementation for the above cannot directly be merged in the code base as the code is not properly factored. However, we would like you to review the code and see how does it align with the purpose of the codec.