Allow for more sophisticated pluralization #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While removing the dependency on ActiveSupport is good, it sometimes results in suboptimal results. Therefore, allow the hosting application to provide the String with a pluralize-method. This could come from ActiveSupport or a custom method, tailored towards the need of the application. If this method is not available, continue with the naïve implementation that works most of the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While removing the dependency on ActiveSupport is good, it sometimes results in suboptimal results.
Therefore, allow the hosting application to provide the String with a pluralize-method. This could come from ActiveSupport or a custom method, tailored towards the need of the application.
If this method is not available, continue with the naïve implementation that works most of the time.