Support EnvoyFilter in Waypoint #3577
Conversation
|
😊 Welcome @zirain! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/L
zirain
added
the
release-notes-none
| string name = 4; | ||
| } | ||
|
|
||
| message WaypointMatch { |
There was a problem hiding this comment.
I think we will need CEL validation in place to ensure that you only use waypoint match when mode is WAYPOINT, and that you don't use other matchers when mode is WAYPOINT.
Also for targetRef service, must be WAYPOINT. For targetRef gateway, must be waypoint or gateway or empty?
There was a problem hiding this comment.
nvm I see you have some of these already, nice
|
|
||
| // One or more match conditions to be met before a patch is applied | ||
| // to the generated configuration for a given proxy. | ||
| // +kubebuilder:validation:XValidation:message="only support waypointMatch when context is WAYPOINT",rule="(self.context == 'WAYPOINT' && has(self.waypoint)) || (self.context != 'WAYPOINT' && !has(self.waypoint))" |
There was a problem hiding this comment.
I think this may fail if self.context is unset. The default function may be handy here
There was a problem hiding this comment.
add default will execced the limit cost of CEL, add a test case for it.
4 participants
RFC: https://docs.google.com/document/d/1hnYJ1P3hYNBALR_2U2h03xJYhyKtcDHLzBAEVEl_pDc/edit?tab=t.0
ProtocolandClusterMatch(subset)is not implemented in the first iterate, we can add them back if needed.