Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Mdspell to Cspell #16335

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

Ajay-singh1
Copy link

@Ajay-singh1 Ajay-singh1 commented Mar 19, 2025

Description

Migrated mdspell to cspell.Fixes #14609

Attached Screenshot:-
Screenshot from 2025-03-19 21-42-43

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@Ajay-singh1 Ajay-singh1 requested review from a team as code owners March 19, 2025 16:32
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test labels Mar 19, 2025
@istio-testing
Copy link
Contributor

Hi @Ajay-singh1. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Ajay-singh1
Copy link
Author

@dhawton

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 20, 2025
@craigbox
Copy link
Contributor

I recommend you get cspell into the build image and then continue.
You will also need to update the script that sorts .spelling and have a plan as to how the exceptions in there are going to move to the new solution.

@craigbox
Copy link
Contributor

#16359 has landed

/retest

@craigbox
Copy link
Contributor

We may need to wait until prow (the CI runner) gets the updated container too. But that should have happened in https://github.com/istio/test-infra/pull/5629/files?

@craigbox
Copy link
Contributor

craigbox commented Mar 27, 2025

/retest

(looking for lint errors not to contain xargs: cspell: No such file or directory. I can run cspell if I pull this branch and run make shell.)

@Ajay-singh1
Copy link
Author

@craigbox I don't know why cspell is not being recognized.Yes you can test it locally.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 27, 2025
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2025
@Ajay-singh1 Ajay-singh1 reopened this Mar 27, 2025
@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2025
@craigbox
Copy link
Contributor

OK, so it's not picked up the new container.
Want to try a new PR and see if that is different?

@dhawton
Copy link
Member

dhawton commented Mar 28, 2025

I don't think it is in the build-tools image:

❯ docker run -it gcr.io/istio-testing/build-tools:master-dbd3c673faecfbd1910fdb09012099fa184dde92 cspell
/usr/local/bin/docker-entrypoint: line 73: exec: cspell: not found

@dhawton
Copy link
Member

dhawton commented Mar 28, 2025

Because it's not... at least, not the build-tools image Prow is using (istio/test-infra#5628). I've approved the bump, so it should be live soon.

❯ docker run -it gcr.io/istio-testing/build-tools:master-4118cfc2b385ebb43ead1f845f744f27e392398b cspell --version
8.17.5

@dhawton
Copy link
Member

dhawton commented Mar 28, 2025

New build-tools ran, lots of lint issues to fix it seems

@Ajay-singh1
Copy link
Author

/test lint

@istio-testing
Copy link
Contributor

@Ajay-singh1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio.io 94ef86c link true /test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update markdown spell check solution
6 participants