Migrated Mdspell to Cspell

[Ajay-singh1]

Description

Migrated mdspell to cspell.Fixes #14609

Attached Screenshot:-

Reviewers

• Ambient
• Docs
• Installation
• Networking
• Performance and Scalability
• Extensions and Telemetry
• Security
• Test and Release
• User Experience
• Developer Infrastructure
• Localization/Translation

[istio-testing]

Hi @Ajay-singh1. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Ajay-singh1]

@dhawton

[Arhell]

/ok-to-test

[craigbox]

I recommend you get cspell into the build image and then continue.
You will also need to update the script that sorts .spelling and have a plan as to how the exceptions in there are going to move to the new solution.

[craigbox]

#16359 has landed

/retest

[craigbox]

We may need to wait until prow (the CI runner) gets the updated container too. But that should have happened in https://github.com/istio/test-infra/pull/5629/files?

[craigbox]

/retest

(looking for lint errors not to contain xargs: cspell: No such file or directory. I can run cspell if I pull this branch and run make shell.)

[Ajay-singh1]

@craigbox I don't know why cspell is not being recognized.Yes you can test it locally.

[craigbox]

OK, so it's not picked up the new container.
Want to try a new PR and see if that is different?

[dhawton]

I don't think it is in the build-tools image:

❯ docker run -it gcr.io/istio-testing/build-tools:master-dbd3c673faecfbd1910fdb09012099fa184dde92 cspell
/usr/local/bin/docker-entrypoint: line 73: exec: cspell: not found

[dhawton]

Because it's not... at least, not the build-tools image Prow is using (istio/test-infra#5628). I've approved the bump, so it should be live soon.

❯ docker run -it gcr.io/istio-testing/build-tools:master-4118cfc2b385ebb43ead1f845f744f27e392398b cspell --version
8.17.5

[dhawton]

New build-tools ran, lots of lint issues to fix it seems

[Ajay-singh1]

/test lint

[istio-testing]

@Ajay-singh1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
lint_istio.io	94ef86c	link	true	/test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[craigbox]

@dhawton my bad, I got #5628 (build tools) and #5629 (common files) PRs mixed up. sorry!

[Ajay-singh1]

@craigbox I don't think we have an issue here this PR is dependent on #16316 if that is merged we will have the test pass here.@dhawton Your opinion is valuable here.

[istio-testing]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.