-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated Mdspell to Cspell #16335
base: master
Are you sure you want to change the base?
Migrated Mdspell to Cspell #16335
Conversation
Hi @Ajay-singh1. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
I recommend you get cspell into the build image and then continue. |
#16359 has landed /retest |
We may need to wait until prow (the CI runner) gets the updated container too. But that should have happened in https://github.com/istio/test-infra/pull/5629/files? |
/retest (looking for lint errors not to contain |
@craigbox I don't know why cspell is not being recognized.Yes you can test it locally. |
OK, so it's not picked up the new container. |
I don't think it is in the build-tools image: ❯ docker run -it gcr.io/istio-testing/build-tools:master-dbd3c673faecfbd1910fdb09012099fa184dde92 cspell |
Because it's not... at least, not the build-tools image Prow is using (istio/test-infra#5628). I've approved the bump, so it should be live soon.
|
New build-tools ran, lots of lint issues to fix it seems |
/test lint |
@Ajay-singh1: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Migrated mdspell to cspell.Fixes #14609
Attached Screenshot:-

Reviewers