Skip to content

Added meta dir for galaxy publish#5

Open
Nick-Andreano wants to merge 8 commits into
itential:devfrom
Nick-Andreano:main
Open

Added meta dir for galaxy publish#5
Nick-Andreano wants to merge 8 commits into
itential:devfrom
Nick-Andreano:main

Conversation

@Nick-Andreano
Copy link
Copy Markdown
Collaborator

Added meta dir for galaxy publish

Comment thread roles/mcp/meta/main.yml Outdated
@@ -0,0 +1,14 @@
galaxy_info:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to investigate this lint error.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different from itential.deployer. Deployer has a runtime.yml file. @Nick-Andreano did this file get generated automatically? Or did you create it?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I read, the meta/runtime is collection level. the mcp/meta/main.yaml is role level. The deployer comes as a combo of redis, mongo, iap, etc roles. Those roles were not ment to be publish independently. The MCP is a single purpose collection wrapping a single role. It makes the single role self-describing in a way that the deployers roles dont need to be. In theory, we could publish the standalone mcp role with this role level file. Even though we are publishing it as its own collection, its still a valid place to put the meta variables.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm second guessing this. I dont think we will ever need to publish the role without the collection and I would rather remain consistent across all of our collection. @kvelarde-itential do you agree?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A role and a collection are different things. A role doesn't have playbooks and so the end user is expected to integrate the role into their own playbooks. We use collections so that things are ready to use. So I believe we should create a collection here.

@Nick-Andreano
Copy link
Copy Markdown
Collaborator Author

@steven-schattenberg-itential The lint error is strange
Error: $.galaxy_info.platforms[1].versions[0] '2023' is not one of ['6.1', '7.1', '7.2', 'all']. See https://docs.ansible.com/projects/ansible/latest/playbook_guide/playbooks_reuse_roles.html#using-role-dependencies

Those map to old AMI versions and Amazon Linux 2, not Amazon Linux 2023. There's no lint-valid string for AL2023 specifically.

I think we can go with "all" and make sure we say its been validated with 2023 in the documentation.
Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants