Skip to content

Conversation

YoungJules
Copy link

Update getTraceString in ErrorDialogPane to show the error message and cause, if available. Catch exceptions that occur in doInBackground of ObjectLoader. This means at least some part of the pdf file gets loaded, although we've hit an error condition in a bad pdf file.

…getTraceString in ErrorDialogPane to show the error message and cause, if available. Catch exceptions that occur in doInBackground of ObjectLoader. This means at least some part of the pdf file gets loaded, although we've hit an error condition in a bad pdf file.
@Eswcvlad
Copy link
Contributor

This means at least some part of the pdf file gets loaded

Hmm, I am not quite sure on how safe it is... My gut feeling says, that RUPS will explode after that at some point. I'd rather keep it like it is here with just an abort for now. And, maybe, revisit partial loading at some later point with some rigorous testing along the way.

As for the messaging change, if you don't mind, I can just cherry-pick it into #172 with authorship preserved and then merge it all together.

@YoungJules
Copy link
Author

YoungJules commented Jul 28, 2025

As for the messaging change, if you don't mind, I can just cherry-pick it into #172 with authorship preserved and then merge it all together.

No worries :-)

I am not quite sure on how safe it is... My gut feeling says, that RUPS will explode after that at some point. I'd rather keep it like it is

No worries... I understand your worries about RUPS exploding...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants