Open
Conversation
Member
|
Author
What do you think now? |
Tchekda
requested changes
Nov 1, 2022
Member
Tchekda
left a comment
Tchekda
left a comment
There was a problem hiding this comment.
- Please do not commit the
vendorfolder - Please update the home page to display if the user is logged or not, if so, display his information (name, vid, etc...)
Comment on lines
+1
to
+30
| APP_NAME=Laravel | ||
| APP_ENV=local | ||
| APP_KEY= | ||
| APP_DEBUG=true | ||
| APP_URL=http://localhost | ||
|
|
||
| LOG_CHANNEL=stack | ||
| LOG_DEPRECATIONS_CHANNEL=null | ||
| LOG_LEVEL=debug | ||
|
|
||
| DB_CONNECTION=mysql | ||
| DB_HOST=127.0.0.1 | ||
| DB_PORT=3306 | ||
| DB_DATABASE=laravel_socialite | ||
| DB_USERNAME=root | ||
| DB_PASSWORD= | ||
|
|
||
| BROADCAST_DRIVER=log | ||
| CACHE_DRIVER=file | ||
| FILESYSTEM_DISK=local | ||
| QUEUE_CONNECTION=sync | ||
| SESSION_DRIVER=file | ||
| SESSION_LIFETIME=120 | ||
|
|
||
| MEMCACHED_HOST=127.0.0.1 | ||
|
|
||
| REDIS_HOST=127.0.0.1 | ||
| REDIS_PASSWORD=null | ||
| REDIS_PORT=6379 | ||
|
|
Member
There was a problem hiding this comment.
Please keep the env file with needed values only and put the IVAO ones there to make the demo work OOTB
Comment on lines
+1
to
+26
| <p align="center"><a href="https://laravel.com" target="_blank"><img src="https://raw.githubusercontent.com/laravel/art/master/logo-lockup/5%20SVG/2%20CMYK/1%20Full%20Color/laravel-logolockup-cmyk-red.svg" width="400" alt="Laravel Logo"></a></p> | ||
|
|
||
| <p align="center"> | ||
| <a href="https://travis-ci.org/laravel/framework"><img src="https://travis-ci.org/laravel/framework.svg" alt="Build Status"></a> | ||
| <a href="https://packagist.org/packages/laravel/framework"><img src="https://img.shields.io/packagist/dt/laravel/framework" alt="Total Downloads"></a> | ||
| <a href="https://packagist.org/packages/laravel/framework"><img src="https://img.shields.io/packagist/v/laravel/framework" alt="Latest Stable Version"></a> | ||
| <a href="https://packagist.org/packages/laravel/framework"><img src="https://img.shields.io/packagist/l/laravel/framework" alt="License"></a> | ||
| </p> | ||
|
|
||
| ## About Laravel | ||
|
|
||
| Laravel is a web application framework with expressive, elegant syntax. We believe development must be an enjoyable and creative experience to be truly fulfilling. Laravel takes the pain out of development by easing common tasks used in many web projects, such as: | ||
|
|
||
| - [Simple, fast routing engine](https://laravel.com/docs/routing). | ||
| - [Powerful dependency injection container](https://laravel.com/docs/container). | ||
| - Multiple back-ends for [session](https://laravel.com/docs/session) and [cache](https://laravel.com/docs/cache) storage. | ||
| - Expressive, intuitive [database ORM](https://laravel.com/docs/eloquent). | ||
| - Database agnostic [schema migrations](https://laravel.com/docs/migrations). | ||
| - [Robust background job processing](https://laravel.com/docs/queues). | ||
| - [Real-time event broadcasting](https://laravel.com/docs/broadcasting). | ||
|
|
||
| Laravel is accessible, powerful, and provides tools required for large, robust applications. | ||
|
|
||
| ## Learning Laravel | ||
|
|
||
| Laravel has the most extensive and thorough [documentation](https://laravel.com/docs) and video tutorial library of all modern web application frameworks, making it a breeze to get started with the framework. |
Member
There was a problem hiding this comment.
In the readme keep only the needed information to run the demo and common bugs.
Please refer to the ReactJS example
Comment on lines
+25
to
+26
| $request->session()->put('token', $ivaoUser->token); | ||
| $request->session()->put('refreshToken', $ivaoUser->refreshToken); |
Member
There was a problem hiding this comment.
Why is this needed if the user object (already storing those values) is also saved in session ?
| Auth::logout(); | ||
| $request->session()->flush(); | ||
|
|
||
| return redirect('https://www.ivao.aero/')->withCookie(cookie($this->cookie_name, '', -3600)); |
Comment on lines
+1
to
+5
| { | ||
| "require": { | ||
| "laravel/socialite": "^5.5" | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Please use the composer.json in the laravel-socialite folder and not the root one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.