Skip to content

fix(sidebar): remove button to close on mobile #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcalor wants to merge 1 commit into from
Closed

fix(sidebar): remove button to close on mobile #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/two-pianos-fly.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ivao/atmosphere-react": minor
---

Make sidebar mobile responsive
4 changes: 3 additions & 1 deletion components/react/src/components/atoms/sidebar/SidebarContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ export const SidebarContainer: ComponentType<PropsWithChildren> = ({
<div className="flex flex-col items-start gap-4 px-4 py-5">
{children}
</div>
<SidebarCollapseButton />
<div className="hidden md:block">
<SidebarCollapseButton />
</div>
</aside>
);
};
Expand Down
2 changes: 1 addition & 1 deletion components/react/src/components/atoms/sidebar/SidebarItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export const SidebarItem = ({
className={cn(
'flex shrink-0 flex-col items-start whitespace-nowrap transition-all',
isSidebarOpen
? `ml-4 ${props.isGroupOpen ? 'w-fit' : 'w-48'} opacity-100`
? `ml-4 w-fit min-w-48 opacity-100`
Copy link
Collaborator

@CptnJon CptnJon Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the goal of that change? It will change the current behavior that subitems of groups will not have a fixed width of 12rem.

Copy link
Contributor Author

@jcalor jcalor Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a fixed width and a long title or description in the sidebar item outside a group will cause them to be cut off

Copy link
Collaborator

@CptnJon CptnJon Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I see. I am not sure whether I like a sidebar with 440px width either. Text-Wrapping looks shit as well. @wolfmaster8 do you have a (good) opinion?

: 'invisible w-0 opacity-0',
)}
>
Expand Down