feat(navbar): add customization options for logo variant, divider sty…#128
feat(navbar): add customization options for logo variant, divider sty…#128alejandro-diazro wants to merge 1 commit intoivaoaero:mainfrom
Conversation
…le, and title formatting
🦋 Changeset detectedLatest commit: 3b4c302 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
im-alfa
requested review from
CptnJon,
Tchekda and
wolfmaster8
and removed request for
wolfmaster8
CptnJon
left a comment
CptnJon
left a comment
There was a problem hiding this comment.
Looks good. Only thing is the width-height but I can imagine why it might be required but I can't test it right now :)
| )} | ||
| <div | ||
| className={cn( | ||
| 'h-8 w-0.5 bg-ocean-400 dark:bg-fuselage-400', |
There was a problem hiding this comment.
Is the change for height and width required?
There was a problem hiding this comment.
If you were to add the logo function on its own, the dividing line would end up looking quite unbalanced. By tweaking these dimensions, you ensure much better visual consistency between the logo and the line. It creates a more harmonious look because the line thickness and the overall height align more naturally with the logo's proportions.
2 participants
Changes
Enhanced the Navbar component with new customization options to provide more flexibility.
New Features
logoVariant prop: Control logo display style
diagonalDivider prop: Toggle divider style
title prop type changed from string to ReactNode