Skip to content

chore: Lint fixes#182

Merged
gimalay merged 3 commits intoiwe-org:masterfrom
renesat:lint-refactoring
Nov 10, 2025
Merged

chore: Lint fixes#182
gimalay merged 3 commits intoiwe-org:masterfrom
renesat:lint-refactoring

Conversation

@renesat
Copy link
Contributor

@renesat renesat commented Nov 9, 2025

Again, a bit of refactoring. I just went through clippy and corrected it. Are you thinking of implementing clippy and rustfmt in CI?

Copy link
Contributor

@gimalay gimalay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes, lots of minor cleanups. Thanks a lot for the help with this!

I'm not sure about using linter in the CI but it makes sense as pre-commit hook. What would you recommend?

Please see the comments. Make sue that you read and agree with https://github.com/iwe-org/iwe/blob/master/CONTRIBUTING.md and I will merge.

Copy link
Contributor Author

@renesat renesat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What We Reject

We will reject pull requests that only contain:

  • Formatting or style changes without functional improvements
  • Linting fixes unrelated to actual issues
  • Typo fixes in code comments or variable names
  • Other trivial changes that don't add meaningful value

Yep, I should have read it :)

I'm not sure about using linter in the CI but it makes sense as pre-commit hook. What would you recommend?

You can add it as an optional task in CI, and it won't affect merges.

Pre-commit is a good thing, but first, it can be bypassed and a PR can be made without linters, and second, not everyone likes forced verification at the commit stage. CI cannot be bypassed with PR and does not require additional verification actions for either maintainers or contributors.

@gimalay
Copy link
Contributor

gimalay commented Nov 10, 2025

While it's just a linter fixes, the changes look good to me. Thanks for the contributing!

Just to make sure, do you agree with this?


Contribution Terms

By submitting a contribution to this project, you agree to the following terms:

  1. License Grant: All contributions submitted to this project will be licensed under the Apache License 2.0, the same license as the project itself.

  2. Rights Transfer: By contributing, you willingly grant all rights to your contribution to the project maintainers and agree that your contribution becomes part of the project under the Apache License 2.0.

  3. Original Work: You certify that your contribution is your original work or that you have the right to submit it under the Apache License 2.0.

  4. No Additional Terms: You understand that no additional terms or conditions will apply to your contributions beyond those specified in the Apache License 2.0.

@gimalay gimalay changed the title Lint refactoring chore: Lint fixes Nov 10, 2025
@renesat
Copy link
Contributor Author

renesat commented Nov 10, 2025

Just to make sure, do you agree with this?

Yes, of course. Nothing particularly specific, it seems. I wasn't going to revoke the code :)

@gimalay gimalay merged commit b5deb6f into iwe-org:master Nov 10, 2025
1 check passed
@gimalay
Copy link
Contributor

gimalay commented Nov 10, 2025

Thanks for your help, much appreciated!

@github-actions github-actions bot mentioned this pull request Nov 10, 2025
@github-actions github-actions bot mentioned this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants