Edits for collective prefix reduction #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonachea
force-pushed
the
co-edit
branch
2 times, most recently
from
f07cca3 to
dbb0916
Compare
Still includes TODO for semantics
Also add some notes below in the temporary text to be removed.
Spell-check
bonachea
changed the title
…ly to default behavior of MAXLOC
…fic image index (excluding examples which use the current team)
bonachea
commented
Oct 26, 2025
There was a problem hiding this comment.
I believe this paper is ready to upload.
@brandongc any final comments?
|
Sometimes we use "image i" and other times we use "image I" Otherwise I agree this is ready. (note this could also be addressed in an r1) |
brandongc
approved these changes
Oct 26, 2025
Great observation! "image I" is also too easy to mis-read as "image 1" (depending on the font), so I've changed them all to "image i" in e6a95f0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.