MotionPath: code enhancement #2446
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization and Refactoring:
createLinearPath()
andcreateCatmullRomPath()
: These methods are almost identical. They can be merged into a single private helper method that takes the curve detail as a parameter.setPathSplineType()
,setCurveTension()
, andsetCycle()
debug node update logic: The logic to remove, clear, and re-attach the debug node is repeated. This can be extracted into a private helper method.Javadoc Grammar and Style Corrections: