Skip to content

Fix resume, proxy, 403 and installer fixes across TUI, extensions and GUI - #425

Merged
m4siha merged 9 commits into
mainfrom
bugfix/resume-proxy-403-installer-and-plugin-fixes
Nov 11, 2026
Merged

m4siha merged 9 commits into
mainfrom
bugfix/resume-proxy-403-installer-and-plugin-fixes

Conversation

Reads fixed-server rules and evaluates PAC scripts in an offscreen
sandbox so downloads follow the browser's proxy. Bumps the extensions
to 0.4.2.

Fixes #381
Keeps each track in a scratch folder beside the .part so a rerun
continues where it stopped, and clears it on remove or redownload.

Refs #328
A server that omits its intermediate now verifies like it does in a
browser; fetched certs must still chain to a bundled root.
@ja7ad ja7ad added this to the v1.3.0 milestone Nov 11, 2026
@ja7ad
ja7ad requested a review from m4siha November 11, 2026 09:20
@ja7ad ja7ad added the bug Something isn't working label Nov 11, 2026

@accesslint accesslint Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 issues across 6 rules (7 WCAG, 4 Best Practice).

Reviewed by AccessLint, which checks every pull request for accessibility issues.

@@ -0,0 +1,10 @@
<!doctype html>
<html>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCAG 2.4.2: Document is missing a <title> element.

Documents must have a <title> element to provide users with an overview of content.

Details

Screen reader users rely on page titles to identify and navigate between tabs/windows. Add a descriptive <title> element in <head> that summarizes the page purpose. Keep titles unique across the site, placing specific content before the site name (e.g., 'Contact Us - Acme Corp').


WCAG 2.4.1: Page has no mechanism to bypass repeated content. Add a <main> landmark or skip link.

Page must have a mechanism to bypass repeated blocks of content.

Details

Missing: no landmarks (<main>, <nav>, <header>, <footer>), no skip link, no headings

Keyboard users must be able to skip repetitive content like navigation. Provide a skip link at the top of the page that links to the main content (e.g., <a href="#main">Skip to main content</a>), or use a <main> landmark. Screen readers can jump directly to landmarks, so a properly marked-up <main> element satisfies this requirement.


Best Practice: Page does not contain a level-one heading.

Page should contain a level-one heading.

Details

A level-one heading (<h1> or role='heading' with aria-level='1') helps users understand the page topic and provides a landmark for screen reader navigation. Each page should have at least one level-one heading that describes the main content, typically matching or similar to the page title.


Best Practice: Page has no main landmark.

Page should have exactly one main landmark.

Details

The main landmark contains the primary content of the page. Screen readers allow users to jump directly to main content. Use a single <main> element (or role='main') to wrap the central content, excluding headers, footers, and navigation.


WCAG 3.1.1: <html> element missing lang attribute.

The <html> element must have a lang attribute.

Details

Screen readers use the lang attribute to determine which language rules and pronunciation to use. Without it, content may be mispronounced. Set lang to the primary language of the page using a BCP 47 code (e.g., 'en' for English, 'es' for Spanish, 'fr' for French, 'de' for German, 'ja' for Japanese, 'zh' for Chinese, 'pt' for Portuguese, 'ar' for Arabic).

<meta charset="utf-8" />
</head>
<body>
<iframe id="pac" src="pac-sandbox.html"></iframe>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCAG 4.1.2: Frame is missing an accessible name. Add a title attribute.

Frames must have an accessible name.

Details

src: "pac-sandbox.html"

Screen readers announce frame titles when users navigate frames. Add a title attribute to <iframe> and <frame> elements that describes the frame's purpose (e.g., <iframe title='Video player'>). Avoid generic titles like 'frame' or 'iframe'. If the frame is decorative, use aria-hidden='true'.

@@ -0,0 +1,7 @@
<!doctype html>
<html>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCAG 2.4.2: Document is missing a <title> element.

Documents must have a <title> element to provide users with an overview of content.

Details

Screen reader users rely on page titles to identify and navigate between tabs/windows. Add a descriptive <title> element in <head> that summarizes the page purpose. Keep titles unique across the site, placing specific content before the site name (e.g., 'Contact Us - Acme Corp').


WCAG 2.4.1: Page has no mechanism to bypass repeated content. Add a <main> landmark or skip link.

Page must have a mechanism to bypass repeated blocks of content.

Details

Missing: no landmarks (<main>, <nav>, <header>, <footer>), no skip link, no headings

Keyboard users must be able to skip repetitive content like navigation. Provide a skip link at the top of the page that links to the main content (e.g., <a href="#main">Skip to main content</a>), or use a <main> landmark. Screen readers can jump directly to landmarks, so a properly marked-up <main> element satisfies this requirement.


Best Practice: Page does not contain a level-one heading.

Page should contain a level-one heading.

Details

A level-one heading (<h1> or role='heading' with aria-level='1') helps users understand the page topic and provides a landmark for screen reader navigation. Each page should have at least one level-one heading that describes the main content, typically matching or similar to the page title.


Best Practice: Page has no main landmark.

Page should have exactly one main landmark.

Details

The main landmark contains the primary content of the page. Screen readers allow users to jump directly to main content. Use a single <main> element (or role='main') to wrap the central content, excluding headers, footers, and navigation.


WCAG 3.1.1: <html> element missing lang attribute.

The <html> element must have a lang attribute.

Details

Screen readers use the lang attribute to determine which language rules and pronunciation to use. Without it, content may be mispronounced. Set lang to the primary language of the page using a BCP 47 code (e.g., 'en' for English, 'es' for Spanish, 'fr' for French, 'de' for German, 'ja' for Japanese, 'zh' for Chinese, 'pt' for Portuguese, 'ar' for Arabic).

Bumps rustix to 1.1.6 and async-executor to 1.14.1; accepts the
unmaintained pin-utils reached through iced's wasmtimer.
@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.74836% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.85%. Comparing base (8eccd4b) to head (bba828b).

Files with missing lines Patch % Lines
crates/hydra-net/src/tls.rs 95.49% 17 Missing ⚠️
crates/hydra-updater/src/lib.rs 86.11% 5 Missing ⚠️
crates/hydra-cli/src/queue.rs 97.67% 1 Missing ⚠️
crates/hydra-cli/src/tui.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   83.73%   83.85%   +0.12%     
==========================================
  Files         111      111              
  Lines       50251    50686     +435     
==========================================
+ Hits        42078    42504     +426     
- Misses       8173     8182       +9     
Files with missing lines Coverage Δ
crates/hydra-cli/src/queue.rs 95.89% <97.67%> (+0.16%) ⬆️
crates/hydra-cli/src/tui.rs 71.61% <0.00%> (ø)
crates/hydra-updater/src/lib.rs 85.97% <86.11%> (+<0.01%) ⬆️
crates/hydra-net/src/tls.rs 85.38% <95.49%> (+10.00%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@m4siha
m4siha merged commit 952376b into main Nov 11, 2026
22 checks passed
@m4siha
m4siha deleted the bugfix/resume-proxy-403-installer-and-plugin-fixes branch November 11, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

2 participants