Pause

[Sophon96]

• handle escape key input
  • disable window close on escape
  • toggle menu on escape
• draw pause menu when active
  • tint screen when pause menu active
  • pause menu interface
  • general layout engine
  • two-column video settings submenu
    • Back button in submenu
    • Fix fullscreen causing mouse position to report incorrectly and decor to disappear
• Grand Refactor
  • Button actions should go in separate methods
  • Layout engine should be separated
  • Button generation should be separated
  • Layout engine should be able to handle another axis of layouts
  • GUI code should be in a separate module
    • GUI should be generic
      • Button should be generic
      • Layouts should be generic
• camera exploding after disabling cursor following switch to SDL

[adamhutchings]

One change, one possible change

[JakeRoggenbuck]

Works!

Would you be able to make the menu pop up for both escape and a letter key (maybe m or p)? I have esc rebound loll and it messes with my caps lock.

[adamhutchings]

Some minor code organization.

[adamhutchings]

I feel like this needs to be a callback instead of an enum. Allows much more easily for the creation of one-time buttons should we ever need them. Example from the near future: list of worlds to load

[Sophon96]

nah i disagree, rust enums are crazy OP and they can pretty much do whatever the heck you want

[JakeRoggenbuck]

Rust enums can contain a string value like:

#[derive(Clone, Copy, PartialEq)]
enum ButtonType {
    BTG,
    QUIT,
    WORLD(String)
}

[adamhutchings]

Possibly, but I still think it should be neater than a match statement to raw blocks of code. At least have back_to_game() and quit() functions defined that can be called by a match statement

[Sophon96]

yeah that seems reasonable; ill probably do a refactor once this pr is ready to review / feature complete

[mileskerr]

you could always add an enum variant with a callback function as a parameter if you want to support callback functions

[JakeRoggenbuck]

Crazy merge conflict

[adamhutchings]

In terms of functionality, this is great though

[Sophon96]

The fullscreen toggle breaks hovering and clicking buttons on my machine; not sure if this is specific to my setup. Would appreciate test results!

[adamhutchings]

Pull from main with the new tests to make sure that CI isn't broken (I know how much you love that!)

[adamhutchings]

Some small changes.

Also, on a more serious note, this has a bug on macOS -- when I test and press "back to game", I snap to looking directly vertically.

[Sophon96]

Yeah, the camera snapping is an issue for me too. Something with the way SDL handles mouse position.

[adamhutchings]

Re: the camera snapping, isn't this exactly why we got rid of GLFW?

[Sophon96]

Re: the camera snapping, isn't this exactly why we got rid of GLFW?

We got rid of GLFW because it had some weird bugs with exiting fullscreen; I think switching to SDL now brings some quirks when locking the cursor

[Sophon96]

No doubt this is the culprit

We should be tracking our own last mouse position and computing delta based on that

[JakeRoggenbuck]

Still having the same issue

[mileskerr]

we have to merge this for the sake of future generations

[mileskerr]

sdl is obviously a bust lets merge this and then i'll start work on getting glfw to work again

[JakeRoggenbuck]

Still build errors with:

jake@Jakes-MacBook-Neo minecrab % source scripts/macos-setup.sh
jake@Jakes-MacBook-Neo minecrab % RUSTFLAGS= LIBRARY_PATH="$(brew --prefix)/lib" cargo r

[JakeRoggenbuck]

Works after installing pkg-config! No issue with window size either

[JakeRoggenbuck]

[JakeRoggenbuck]

Works!