Add settings for user#76
Conversation
|
We can later add UI so the user can edit their render distance and all future settings |
JakeRoggenbuck
requested review from
Sophon96 and
mileskerr
and removed request for
mileskerr
|
Oh i forgot it doesn't let you click two people for a review, but i would love a review from both of you! |
|
great to have this early i think so we dont have to replace a ton of constants later! only nitpick is that render distance should probably be unsigned? |
|
Good call! I was thinking that too. I'd have to do a type cast each time the render future chunk is called, but that should be fast enough. Thanks! |
|
|
||
| pub fn generate_surrounding_chunks(&mut self, px: i64, py: i64, pz: i64, radius: i64) { | ||
| pub fn generate_surrounding_chunks(&mut self, px: i64, py: i64, pz: i64, radius: u32) { | ||
| let render_distance = radius as i64; |
There was a problem hiding this comment.
not sure if im misreading the formatting, but shouldn't this line be indented once more?
There was a problem hiding this comment.
oh yes it def should be loll good catch!
|
Silly tabs and spaces on my new vim install on my new mac lol |
adamhutchings
left a comment
adamhutchings
left a comment
There was a problem hiding this comment.
Looks good to me! In the future we can hook this up to UI
|
Yes! |
4 participants
No description provided.