Clean up: #1
Open
Clean up: #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 14, 2024 01:20
Moved all commands to new file, with dictionary function mapping for clarity, reuse, and (due to a bug) performance. Likewise, added similar functionality for command arguments. I'm not sure if this new logic is actually better, but it's a little cleaner and more extensible Added context class for ease of arg passing Inverted ifs for readability Removed some unused and/or redundant code Moved some logic to helper functions (send_message, ffmpeg_clean, get_voice) unfortunately it's all untested, you can test this your self or just use it for reference
Moved all commands to new file, with dictionary function mapping for clarity, reuse, and (due to a bug) performance. Likewise, added similar functionality for command arguments. I'm not sure if this new logic is actually better, but it's a little cleaner and more extensible Added context class for ease of arg passing Inverted ifs for readability Removed some unused and/or redundant code Moved some logic to helper functions (send_message, ffmpeg_clean, get_voice) unfortunately it's all untested, you can test this your self or just use it for reference
# Conflicts: # commands.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all commands to new file, with dictionary function mapping for clarity, reuse, and (due to a bug) performance.
Likewise, added similar functionality for command arguments. I'm not sure if this new logic is actually better, but it's a little cleaner and more extensible
Added context class for ease of arg passing
Inverted ifs for readability
Removed some unused and/or redundant code
Moved some logic to helper functions (send_message, ffmpeg_clean, get_voice)
unfortunately it's all untested, you can test this your self or just use it for reference