Skip to content

use older os to compiler so dynamic libraries work better #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: z80
Choose a base branch
from
Open

use older os to compiler so dynamic libraries work better #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88ca593
use older os to compiler so dynamic libraries work better
mateoconlechuga May 21, 2023
79f4077
fix previous commit
mateoconlechuga May 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
runs-on: [ubuntu-latest, macos-latest, windows-latest]
runs-on: [ubuntu-20.04, macos-11, windows-latest]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: [ubuntu-20.04, macos-11, windows-latest]
runs-on: [ubuntu-20.04, ubuntu-latest, macos-11, macos-latest, windows-latest]

build-type: [Release]
runs-on: ${{matrix.runs-on}}
steps:
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
strategy:
fail-fast: false
matrix:
runs-on: [ubuntu-latest, macos-latest, windows-latest]
runs-on: [ubuntu-20.04, macos-11, windows-latest]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: [ubuntu-20.04, macos-11, windows-latest]
runs-on: [ubuntu-20.04, ubuntu-latest, macos-11, macos-latest, windows-latest]

build-type: [Release]
runs-on: ${{matrix.runs-on}}
steps:
Expand Down Expand Up @@ -280,7 +280,7 @@ jobs:
strategy:
fail-fast: false
matrix:
runs-on: [ubuntu-latest, macos-latest, windows-latest]
runs-on: [ubuntu-20.04, macos-11, windows-latest]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: [ubuntu-20.04, macos-11, windows-latest]
runs-on: [ubuntu-20.04, ubuntu-latest, macos-11, macos-latest, windows-latest]

build-type: [Release]
runs-on: ${{matrix.runs-on}}
steps:
Expand Down Expand Up @@ -332,7 +332,7 @@ jobs:
strategy:
fail-fast: false
matrix:
runs-on: [ubuntu-latest, macos-latest, windows-latest]
runs-on: [ubuntu-20.04, macos-11, windows-latest]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: [ubuntu-20.04, macos-11, windows-latest]
runs-on: [ubuntu-20.04, ubuntu-latest, macos-11, macos-latest, windows-latest]

build-type: [Debug]
continue-on-error: true
if: false
Expand Down Expand Up @@ -382,7 +382,7 @@ jobs:
strategy:
fail-fast: false
matrix:
runs-on: [ubuntu-latest, macos-latest, windows-latest]
runs-on: [ubuntu-20.04, macos-11, windows-latest]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: [ubuntu-20.04, macos-11, windows-latest]
runs-on: [ubuntu-20.04, ubuntu-latest, macos-11, macos-latest, windows-latest]

build-type: [Debug]
continue-on-error: true
if: false
Expand Down