Skip to content

Conversation

@tophrr
Copy link

@tophrr tophrr commented Sep 20, 2020

Himawari 8 server now redirects HTTP request to HTTPS and HTTP no longer works, so changing base url from HTTP to HTTPS is the easiest way to fix. Before, by checking and allowing only 200 status code will result in Invalid status code.

Himawari 8 server now redirects HTTP request to HTTPS, and HTTP no longer works
@ungoldman
Copy link
Contributor

ungoldman commented Sep 30, 2020

Makes sense to me! I can approve and merge here but I'm not a collaborator on npm so I'm unable to publish this fix.

I'll hold off on approving until @jakiestfu is able to respond (and maybe share keys to npm package).

Edit: never mind, for some reason I thought I was a maintainer but I am mistaken.

@ungoldman
Copy link
Contributor

Hey @jakiestfu I'm going to fork this project and publish a new version with this fix under a scoped namespace (@ungoldman/himawari) just to be able to work with this module again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants