fixed transcription is not received when call is terminated#1259
fixed transcription is not received when call is terminated#1259davehorton merged 10 commits intomainfrom
Conversation
|
Hi @davehorton @vdharashive @rammohan-y My solution is for fixing transcription is not received when call is terminated by: The transcription issue are: To fix above issue, If JAMBONES_TRANSCRIBE_EP_DESTROY_DELAY_MS is enabled, this PR does graceful shutdown for the endpoint by: 3/ override endpoint destroy: if the endpoint is in transcribe task, the destroy will be delayed until one of condition is matched: transcription is received or JAMBONES_TRANSCRIBE_EP_DESTROY_DELAY_MS timeout is passed. Please help me to review the PR and let me know if something need to be fixed |
|
@xquanluu we found two cases in which the stopTranscription should stop immediately even if the JAMBONES_TRANSCRIBE_EP_DESTROY_DELAY_MS is set, one is when stopTranscription is invoked during ASR fallback and stopTranscription invoked when the call transcription_status is paused Can you address these scenarios As the PR is big, it will take some time to test |
|
This PR fixes all the issues, delayed termination and delayed stopTranscription when JAMBONES_TRANSCRIBE_EP_DESTROY_DELAY_MS is specified. |
#1246
#997