Fixed handling of bargein and dtmfBargein parameters.#1388
Open
dmitrikozlov wants to merge 2 commits intojambonz:mainfrom
Open
Fixed handling of bargein and dtmfBargein parameters.#1388dmitrikozlov wants to merge 2 commits intojambonz:mainfrom
dmitrikozlov wants to merge 2 commits intojambonz:mainfrom
Conversation
- Fix dtmfBargein: only interrupt prompt when dtmfBargein=true - Fix bargein: only interrupt prompt when bargein=true - Collect input during prompt and resolve after completion when bargein=false - Only kill audio in _resolve if prompt is still playing - Handle edge case when no prompt exists
Contributor
|
@xquanluu need your review here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the following test cases
Case 1
Expected: Bargein with DTMF doesn’t happen
Result Bargein with either DTMF or speech still happens
Case 2
Expected: Bargein with DTMF or Speech doesn’t happen
Result Barge-in with either DTMF or speech still happens
Case 3
Expected: User can bargein prompts with DTMF or speech. Bardein happens almost immediately after a DTMF or speech input.
Result: Bargein with DTMF works as expected; Bargein with speech behaves badly. Sometimes bargein happens on no speech input—background noise? Sometimes prompts are interrupted either on the first spoken word or on the second or even third. The user app may receive all of the spoken words or only the first spoken word when interrupted after the second spoken word.
Case 4
Expected: prompt plays to the end
Result: prompt interrupted with either speech or DTMF.