Conversation
davehorton
reviewed
Nov 18, 2025
Contributor
Author
|
@davehorton comments have been incoporated into PR. |
vdharashive
added a commit
to vdharashive/jambonz-feature-server
that referenced
this pull request
Nov 19, 2025
- Add null-safe handling for options parameter using nullish coalescing (??) - Parse options once and reuse the parsed result - Handle cases where options or voice_settings might be undefined - Prevents errors when TTS stream is invoked without configuration Related to issue jambonz#1413 Co-authored-by: oddsix <ed@erobbins.com>
Contributor
|
please rebase |
Contributor
Author
|
@davehorton done |
Contributor
|
@oddsix the main issue of having config verb to use option properties still not working |
Contributor
|
@davehorton @oddsix we can merge this , since this will solve the problem of current code, currently we can't use elevenlab due to error , we can continue to work on fixing issue of gather with ttstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.