Skip to content

fixed: should start transcription and timeout timer when listenDuringPrompt=true #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xquanluu wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fixed: should start transcription and timeout timer when listenDuringPrompt=true #1477

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
922a034
fixed: should start transcription and timeout timer when listenDuring…
xquanluu Dec 17, 2025
647f4ab
wip
xquanluu Dec 17, 2025
58cb19d
wip
xquanluu Dec 17, 2025
fe84560
Merge branch 'main' into fix/fd_1738_02
xquanluu Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 16 additions & 20 deletions lib/tasks/gather.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,17 +230,17 @@ class TaskGather extends SttTask {
};

const startListening = async(cs, ep) => {
if (this.killed || this.resolved) {
this.logger.info('Gather:exec - task was quickly killed so do not transcribe');
return;
}
this._startTimer();
if (this.isContinuousAsr && 0 === this.timeout && !this.isBackgroundGather) {
this._startAsrTimer();
}
if (this.input.includes('speech') && !this.listenDuringPrompt) {
if (this.input.includes('speech')) {
try {
await this._setSpeechHandlers(cs, ep);
if (this.killed) {
this.logger.info('Gather:exec - task was quickly killed so do not transcribe');
return;
}
this._startTranscribing(ep);
} catch (e) {
await this._startFallback(cs, ep, {error: e});
Expand All @@ -259,7 +259,9 @@ class TaskGather extends SttTask {
}
this._stopVad();
if (!this.killed && !this.resolved) {
startListening(cs, ep);
if (!this.listenDuringPrompt) {
startListening(cs, ep);
}
if (this.input.includes('speech') && this.vendor === 'nuance' && this.listenDuringPrompt) {
this.logger.debug('Gather:exec - starting transcription timers after say completes');
ep.startTranscriptionTimers((err) => {
Expand Down Expand Up @@ -297,14 +299,17 @@ class TaskGather extends SttTask {
}
this._stopVad();
if (!this.killed && !this.resolved) {
startListening(cs, ep);
if (!this.listenDuringPrompt) {
startListening(cs, ep);
}
if (this.input.includes('speech') && this.vendor === 'nuance' && this.listenDuringPrompt) {
this.logger.debug('Gather:exec - starting transcription timers after play completes');
ep.startTranscriptionTimers((err) => {
if (err) this.logger.error({err}, 'Gather:exec - error starting transcription timers');
});
}
}

};
this.playTask.span = span;
this.playTask.ctx = ctx;
Expand All @@ -321,21 +326,12 @@ class TaskGather extends SttTask {
});
}
else {
if (this.killed) {
this.logger.info('Gather:exec - task was immediately killed so do not transcribe');
return;
}
startListening(cs, ep);
// listenDuringPrompt is set to false if there is no say or play task
await startListening(cs, ep);
}

if (this.input.includes('speech') && this.listenDuringPrompt) {
await this._setSpeechHandlers(cs, ep);
if (!this.resolved && !this.killed) {
this._startTranscribing(ep);
}
else {
this.logger.info('Gather:exec - task was killed or resolved quickly, not starting transcription');
}
if (this.listenDuringPrompt) {
await startListening(cs, ep);
}

// https://github.com/jambonz/jambonz-feature-server/issues/913
Expand Down