Skip to content

Do not crop leading plus #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avoylenko wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Do not crop leading plus #167

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e1b094
fix: do not crop leading plus
avoylenko Feb 20, 2025
530f979
refactor: eslint warning
avoylenko Feb 20, 2025
505dedd
Merge branch 'main' into fix-leading-plus
avoylenko Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/call-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,13 +315,12 @@ class CallSession extends Emitter {
if (gws.length) {
uris = [];
gws.forEach((o) => {
const calledNumber = this.req.calledNumber.startsWith('+') ?
this.req.calledNumber.slice(1) :
this.req.calledNumber;
const calledNumber = this.req.calledNumber;
const prefix = vc.tech_prefix || '';
const transport = o.protocol?.startsWith('tls') ? 'tls' : (o.protocol || 'udp');
const hostport = !o.port || 5060 === o.port ? o.ipv4 : `${o.ipv4}:${o.port}`;
const prependPlus = vc.e164_leading_plus && !this.req.calledNumber.startsWith('0') ? '+' : '';
const prependPlus = vc.e164_leading_plus &&
!(calledNumber.startsWith('+') || calledNumber.startsWith('0')) ? '+' : '';
const scheme = transport === 'tls' && !process.env.JAMBONES_USE_BEST_EFFORT_TLS && o.use_sips_scheme ?
'sips' : 'sip';
let u = `${scheme}:${prefix}${prependPlus}${calledNumber}@${hostport};transport=${transport}`;
Expand Down