added 2 delegate methods for above/below insertion #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 23, 2012 20:17
…rAbove) so you can choose the insertion method
…ea and slides in.
you have to alter your viewForRightSidebar-method, the controller.view.frame should only be set, when the SideBarViewController is not visible.
e.g
if(self.navigationController.revealedState == JTRevealedStateRight) {
// not visible as JTRevealedStateRight is the finished state after the animation
controller.view.frame = CGRectMake(0, viewFrame.origin.y, 180, viewFrame.size.height);
controller.view.autoresizingMask = UIViewAutoresizingFlexibleRightMargin | UIViewAutoresizingFlexibleHeight;
}
…RightSidebarStyle create JTRevealedStyle-enum
|
I am afraid I would like to see there's some way we can keep the original behaviour (the original sidebar keeps at the bottom and not pushing out by default; And use your nice push effect when they enabled that option) Besides, I can see in current patch users can simply returns JTRevealedStyleMainSticky, then they would be confused because no sidebar would be laid out. I would suggest it should be better encapsulated into following options: typedef NS_OPTIONS(NSUInteger, JTRevealedStyle) {
JTRevealedStyleDefault,
JTRevealedStylePush,
JTRevealedStyleOnTop
};Any thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(viewForLeftSidebarAbove, viewForRightSidebarAbove) so you can choose the insertion method.
Now i can can use a drop shadow on the SideBarView
This time the revealedView is slided in synchronized with the main view.
It's implemented just for right side.