Add tests for - and / #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeaye
reviewed
Dec 22, 2024
| (is (NaN? (- ##NaN))) | ||
|
|
||
| (is (thrown? Exception (- ##NaN nil))) | ||
| (is (thrown? Exception (- ##Inf nil)))) |
There was a problem hiding this comment.
For both of these, it'd be good to have a test case for the variadic arity. i.e. (apply - (range 20))
|
Sorry about the wait. I just pushed some updates that add more multi-arg and single-arg tests. |
|
Excellent work! Thanks for all of the help. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new tests for:
-/