Skip to content

Test mapcat #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2025
Merged

Test mapcat #763

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65d9a42
test `mapcat` (#354)
christos-chatzifountas-biotz-io Sep 29, 2025
ffb1ee9
Address comments
E-A-Griffin Oct 15, 2025
17cba90
cljs the problem child
E-A-Griffin Oct 15, 2025
098f5ad
Whoops
E-A-Griffin Oct 15, 2025
fd58559
into [] -> doall
E-A-Griffin Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion project.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
:url "https://github.com/jank-lang/clojure-test-suite"
:license {:name "MPL 2.0"
:url "https://www.mozilla.org/en-US/MPL/2.0/"}
:dependencies [[org.clojure/clojure "1.12.0"]]
:dependencies [[org.clojure/clojure "1.12.0"]
[org.clojure/clojurescript "1.12.42"]]
Copy link
Collaborator Author

@E-A-Griffin E-A-Griffin Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cider doesn't work on this project without this, @jeaye if you want me to do this in a separate PR that's fine but I think we should have it

:plugins [[com.jakemccrary/lein-test-refresh "0.25.0"]])
7 changes: 5 additions & 2 deletions test/clojure/core_test/mapcat.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
(ns clojure.core-test.mapcat
(:require [clojure.test :as t :refer [deftest testing is]]
[clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
[clojure.core-test.portability :refer-macros [when-var-exists]]))


(when-var-exists mapcat
Expand Down Expand Up @@ -56,4 +56,7 @@
(mapcat 42 [1 2]))))
(testing "non-concatable return value"
(is (thrown? #?(:cljs :default :default Exception)
(mapcat identity (range 2)))))))
;; we need to realize the lazy data structure
;; in order for `cljs` to throw on the result
;; hence `(into [])`
(into [] (mapcat identity (range 2))))))))
Loading