parse functions #90
Open
parse functions #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeaye
reviewed
Jul 6, 2025
Comment on lines
+10
to
+17
| false "false" | ||
| true "true" | ||
| nil "" | ||
| nil "foo" | ||
| nil "False" | ||
| nil "FALSE" | ||
| nil "True" | ||
| nil "TRUE")) |
There was a problem hiding this comment.
These parsing functions are quite involved, so I think we can have quite a bit more rigor here.
Would be good to have edge case tests for prefix/suffix (i.e. ttrue and truee). Also good to have tests for number strings (since 1 is commonly convertible to bool). Also, we should test for how whitespace is handled (on either end, and in the middle).
jeaye
reviewed
Jul 6, 2025
Comment on lines
+9
to
+12
| (are [expected x] (= expected (parse-uuid x)) | ||
| nil "" | ||
| nil "0" | ||
| nil "df0993") |
There was a problem hiding this comment.
What if it's a valid UUID + some extra?
jeaye
reviewed
Jul 6, 2025
Comment on lines
+10
to
+11
| nil "" | ||
| nil "foo" |
There was a problem hiding this comment.
Clojure also supports scientific notation, like 1.5e10, which also supports uppercase E.
jeaye
reviewed
Jul 6, 2025
| 1.0 "1.000" | ||
| 5.6 "+5.6" | ||
| -8.7 "-8.7" | ||
| ##Inf "Infinity" |
There was a problem hiding this comment.
What about the edge case of two numbers next two each other, like Infinity7?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.