Skip to content

Conversation

@zrisher
Copy link

@zrisher zrisher commented Jan 18, 2017

This PR adds a bit more detail to the readme around two major stumbling blocks for new users:

  • It's unclear where LocalStrategy in the first code example comes from
  • It's unclear that body-parser is required for fields to be available in req.body, where passport-local expects them.

I haven't seen anyone complaining about the former, but it was a bit confusing for me and easy enough to fix as part of this PR.

There's plenty of examples of people having issues with the latter:

@coveralls
Copy link

coveralls commented Jan 18, 2017

Coverage Status

Coverage remained the same at 97.619% when pulling 3282b88 on zrisher:master into 3b9980f on jaredhanson:master.

@gabrielcsapo
Copy link

👍 this is so needed, quick glance would be so helpful with this information!

bump @jaredhanson

rwky added a commit to passport-next/passport-local that referenced this pull request Jul 7, 2018
@rwky
Copy link

rwky commented Jul 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants