all api endpoints should be https. requesting merge for oauth2 implementation. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi, please merge my push. thanks! |
|
+1 |
funkyfundev
changed the title
Author
|
Also added implementation for oauth2 strategy. Please review and merge. |
|
@francisalvinbarretto I am using your OAuth2 fork of this repo and am getting the errror: Any way to fix this error? I'm not sure where utils is being defined. |
Removing debug messages
Update oauth2.js
Base the implementation on passport-oauth2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge my changes for modifying the endpoint to use "https" instead of "http". Yahoo only accepts https requests for all endpoints.
Thanks!